Re: [PATCH] block: mtip32xx: Remove unnecessary function calls

From: Damien Le Moal
Date: Wed Jan 22 2025 - 01:02:29 EST


On 1/21/25 1:20 AM, Philipp Stanner wrote:
> pcim_iounmap_regions() does not have to be called, because the regions
> are automatically unmapped since they were mapped with managed
> functions. Moreover, that function is deprecated anyways.
>
> Furthermore, setting the drvdata to NULL is unnecessary in a driver
> remove() function.
>
> Remove the unnecessary calls.
>
> Signed-off-by: Philipp Stanner <phasta@xxxxxxxxxx>

Looks OK to me.

Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>

--
Damien Le Moal
Western Digital Research