Re: [PATCH] f2fs: fix to avoid changing 'check only' behaior of recovery

[Chao Yu]

On 1/21/25 10:15, Zhiguo Niu wrote:
> The following two 'check only recovery' processes are very dependent on
> the return value of f2fs_recover_fsync_data, especially when the return
> value is greater than 0.
> 1. when device has readonly mode, shown as commit
> 23738e74472f ("f2fs: fix to restrict mount condition on readonly block device")
> 2. mount optiont NORECOVERY or DISABLE_ROLL_FORWARD is set, shown as commit
> 6781eabba1bd ("f2fs: give -EINVAL for norecovery and rw mount")
>
> However, commit c426d99127b1 ("f2fs: Check write pointer consistency of open zones")
> will change the return value unexpectedly, thereby changing the caller's behavior
>
> This patch let the f2fs_recover_fsync_data return correct value,and not do
> f2fs_check_and_fix_write_pointer when the device is read-only.
>
> Fixes: c426d99127b1 ("f2fs: Check write pointer consistency of open zones")
> Signed-off-by: Zhiguo Niu <zhiguo.niu@xxxxxxxxxx>

Reviewed-by: Chao Yu <chao@xxxxxxxxxx>

Thanks,