Re: [RFC v3 07/18] dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Controller
From: Krzysztof Kozlowski
Date: Wed Jan 22 2025 - 03:22:55 EST
On 21/01/2025 22:58, Michal Wilczynski wrote:
>>> +maintainers:
>>> + - Michal Wilczynski <m.wilczynski@xxxxxxxxxxx>
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - thead,th1520-reset
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + "#reset-cells":
>>> + const: 0
>>
>> Should this be "const: 1" instead?
>
> Right now I'm not planning to extend by more resets, I've thought about
> this during the discussion on v2 of this patchset. At this point I just
> can't see more interesting resets to have. Vendor kernel implements WDT
> and NPU. I don't think NPU driver will be upstream anytime soon. That
> would leave WDT reset potentially.
Bindings should be complete, regardless whether you implement reset
consumer driver or not.
Best regards,
Krzysztof