Re: [PATCH] rust: Do not export generated KASAN ODR symbols

[Alice Ryhl]

On Wed, Jan 22, 2025 at 1:14 AM Matthew Maurer <mmaurer@xxxxxxxxxx> wrote:
>
> ASAN generates sppecial synthetic symbols to help check for ODR

Typo: sppecial

> violations. These synthetic symbols lack debug information, so
> gendwarfksyms emits warnings when processing them. No code should ever
> have a dependency on these symbols, so we should not be exporting them,
> just like the __cfi symbols.
>
> Signed-off-by: Matthew Maurer <mmaurer@xxxxxxxxxx>

Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>

>  rust/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/Makefile b/rust/Makefile
> index ab300bfb46f6a3e386b86d58120d7aeddc57da37..4f212bd41e74ec9f25445d3af76818332f288e15 100644
> --- a/rust/Makefile
> +++ b/rust/Makefile
> @@ -329,7 +329,7 @@ $(obj)/bindings/bindings_helpers_generated.rs: private bindgen_target_extra = ;
>  $(obj)/bindings/bindings_helpers_generated.rs: $(src)/helpers/helpers.c FORCE
>         $(call if_changed_dep,bindgen)
>
> -rust_exports = $(NM) -p --defined-only $(1) | awk '$$2~/(T|R|D|B)/ && $$3!~/__cfi/ { printf $(2),$$3 }'
> +rust_exports = $(NM) -p --defined-only $(1) | awk '$$2~/(T|R|D|B)/ && $$3!~/__cfi/ && $$3!~/__odr_asan/ { printf $(2),$$3 }'
>
>  quiet_cmd_exports = EXPORTS $@
>        cmd_exports = \
>
> ---
> base-commit: 0939156bc07c9fd2b554d9813352c386dacfc3d9
> change-id: 20250116-gendwarfksyms-kasan-rust-2bdbac027f88
>
> Best regards,
> --
> Matthew Maurer <mmaurer@xxxxxxxxxx>
>