Re: [PATCH v8 3/7] rust: time: Introduce Instant type

[FUJITA Tomonori]

On Thu, 16 Jan 2025 21:06:44 +0900 (JST)
FUJITA Tomonori <fujita.tomonori@xxxxxxxxx> wrote:

> On Thu, 16 Jan 2025 10:32:45 +0100
> Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
> 
>>> -impl Ktime {
>>> -    /// Create a `Ktime` from a raw `ktime_t`.
>>> +impl Instant {
>>> +    /// Create a `Instant` from a raw `ktime_t`.
>>>      #[inline]
>>> -    pub fn from_raw(inner: bindings::ktime_t) -> Self {
>>> +    fn from_raw(inner: bindings::ktime_t) -> Self {
>>>          Self { inner }
>>>      }
>> 
>> Please keep this function public.
> 
> Surely, your driver uses from_raw()?

I checked out the C version of Binder driver and it doesn't seem like
the driver needs from_raw function. The Rust version [1] also doesn't
seem to need the function. Do you have a different use case?

https://r.android.com/3004103 [1]