Re: [PATCH] mm/slab: Achieve better kmalloc caches randomization in kvmalloc

[Christoph Lameter (Ampere)]

On Wed, 22 Jan 2025, GONG Ruiqi wrote:

>
> +void *__kmalloc_node_inline(size_t size, kmem_buckets *b, gfp_t flags,
> +				int node, unsigned long caller);
> +


Huh? Is this inline? Where is the body of the function?

> diff --git a/mm/slub.c b/mm/slub.c
> index c2151c9fee22..ec75070345c6 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -4319,6 +4319,13 @@ void *__kmalloc_node_track_caller_noprof(DECL_BUCKET_PARAMS(size, b), gfp_t flag
>  }
>  EXPORT_SYMBOL(__kmalloc_node_track_caller_noprof);
>
> +__always_inline void *__kmalloc_node_inline(size_t size, kmem_buckets *b,
> +					    gfp_t flags, int node,
> +					    unsigned long caller)
> +{
> +	return __do_kmalloc_node(size, b, flags, node, caller);
> +}
> +

inline functions need to be defined in the header file AFAICT.