Re: [PATCH v2 0/5] A mechanism for efficient support for per-function metrics

From: James Clark
Date: Wed Jan 22 2025 - 11:47:42 EST




On 06/01/2025 12:01 pm, mark.barnett@xxxxxxx wrote:
From: Mark Barnett <mark.barnett@xxxxxxx>

This patch introduces the concept of an alternating sample rate to perf
core and provides the necessary basic changes in the tools to activate
that option.


[...]

Changes since v1:
- Rebased onto perf-tools-next, as per request from Ian Rogers.
- Removed unnecessary code that truncated period_left to 0 and restarted
the PMU.
- Renamed variables to use the shorter 'alt_period' instead of
'alterantive_period'.
- Added patch #5 that addresses an issue in the x86 and PowerPC drivers that
caused the opposite period to be reported in the sample record.

It sounds like it would be better if patch 5 comes first otherwise the feature is introduced as broken.