Re: [PATCH v5 2/4] input: apple_z2: Add a driver for Apple Z2 touchscreens

[Sasha Finkelstein]

On Wed, 22 Jan 2025 at 07:18, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:
> > +     z2->input_dev->phys = "apple_z2";
>
> Phys is supposed to be unique, however my understanding there could be 2
> devices in the system?

All existing devices have at most one z2 device, and while i do not
have visibility
into future apple product decisions, judging by the current stack, it seems
unlikely for them to make one that needs two of them.

> -static int apple_z2_build_cal_blob(struct apple_z2 *z2, u32 address, size_t cal_size, char *data)
> +/* Build calibration blob, caller is responsible for freeing the blob data. */

A comment on a previous version of this patch requested to not have functions
that require the caller to free the return value
https://lore.kernel.org/all/ZAlM2DzMmwzWIZEF@nixie71/