Re: [PATCH] clk: qcom: camcc-sm8250: Use clk_rcg2_shared_ops for some RCGs

[Dmitry Baryshkov]

On Wed, Jan 22, 2025 at 09:34:27PM +0000, Jordan Crouse wrote:
> Update some RCGs on the sm8250 camera clock controller to use
> clk_rcg2_shared_ops. The shared_ops ensure the RCGs get parked
> to the XO during clock disable to prevent the clocks from locking up
> when the GDSC is enabled. These mirror similar fixes for other controllers
> such as commit 8d4025943e13 ("clk: qcom: camcc-sc7180: Use runtime PM ops
> instead of clk ones").

I'm not sure, how the mentioned commit is relevant to this fix.
Did you mean e5c359f70e4b ("clk: qcom: camcc: Update the clock ops for the SC7180")?

> 
> Signed-off-by: Jordan Crouse <jorcrous@xxxxxxxxxx>
> ---
> 
>  drivers/clk/qcom/camcc-sm8250.c | 56 ++++++++++++++++-----------------
>  1 file changed, 28 insertions(+), 28 deletions(-)
> 
> diff --git a/drivers/clk/qcom/camcc-sm8250.c b/drivers/clk/qcom/camcc-sm8250.c
> index 34d2f17520dc..450ddbebd35f 100644
> --- a/drivers/clk/qcom/camcc-sm8250.c
> +++ b/drivers/clk/qcom/camcc-sm8250.c
> @@ -411,7 +411,7 @@ static struct clk_rcg2 cam_cc_bps_clk_src = {
>  		.parent_data = cam_cc_parent_data_0,
>  		.num_parents = ARRAY_SIZE(cam_cc_parent_data_0),
>  		.flags = CLK_SET_RATE_PARENT,
> -		.ops = &clk_rcg2_ops,
> +		.ops = &clk_rcg2_shared_ops,
>  	},
>  };
>  

-- 
With best wishes
Dmitry