Re: [PATCH] dt-bindings: omap: Add TI Pandaboard A4 variant

[Andreas Kemnade]

Am Wed, 22 Jan 2025 08:20:58 -0600
schrieb Tom Rini <trini@xxxxxxxxxxxx>:

> On Wed, Jan 22, 2025 at 09:32:36AM +0100, Andreas Kemnade wrote:
> > Am Tue, 21 Jan 2025 18:12:40 -0600
> > schrieb Tom Rini <trini@xxxxxxxxxxxx>:
> >   
> > > Document the ti,omap4-panda-a4 compatible string in the appropriate
> > > place within the omap family binding file.
> > > 
> > > Signed-off-by: Tom Rini <trini@xxxxxxxxxxxx>
> > > ---
> > > Cc: Aaro Koskinen <aaro.koskinen@xxxxxx>
> > > Cc: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> > > Cc: Kevin Hilman <khilman@xxxxxxxxxxxx>
> > > Cc: Roger Quadros <rogerq@xxxxxxxxxx>
> > > Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> > > Cc: Rob Herring <robh@xxxxxxxxxx>
> > > Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> > > Cc: Conor Dooley <conor+dt@xxxxxxxxxx>
> > > Cc: linux-omap@xxxxxxxxxxxxxxx
> > > Cc: devicetree@xxxxxxxxxxxxxxx
> > > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > > ---
> > >  Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > > index 93e04a109a12..28e23ca766b4 100644
> > > --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > > @@ -137,6 +137,7 @@ properties:
> > >                - motorola,xyboard-mz609
> > >                - motorola,xyboard-mz617
> > >                - ti,omap4-panda
> > > +              - ti,omap4-panda-a4
> > >                - ti,omap4-sdp
> > >            - const: ti,omap4430
> > >            - const: ti,omap4  
> > 
> > This allows compatible = "ti,omap4-panda-a4", "ti,omap4430", "ti,omap4"
> > 
> > According to your other patch, you want
> > compatible = "ti,omap4-panda-a4", "ti,omap4-panda", "ti,omap4430",
> > "ti,omap4"
> > 
> > so you need a construction similar to the "ti,omap3-beagle-ab4"  
> 
> Do you mean the order should change, or it should be an enum? I'm not
> sure where this is documented (the $id and $schema values in the file
> are just 404s so I guess not something to read directly?).
> 
you would need a block like this:

      - description: Early Pandaboard revision A4
        items:
          - const: ti,omap4-panda-a4
          - const: ti,omap4-panda
          - const: ti,omap4430
          - const: ti,omap4


Regards,
Andreas