RE: [PATCH] scsi: ufs: Move clock gating sysfs entries to ufs-sysfs.c

[Avri Altman]

> On 1/22/25 6:36 AM, Avri Altman wrote:
> > +static ssize_t
> > +clkgate_enable_show(struct device *dev, struct device_attribute *attr,
> > +                 char *buf)
> > +{
> 
> The above formatting does not conform to the Linux kernel coding style.
> Please fix this, e.g. by running git clang-format HEAD^ && git commit --amend
> on the git branch with this patch.
Done.
AFAIK, there hasn't been a formal announcement that `clang-format` should replace `checkpatch` for Linux kernel development.
And yes, while checkpatch --strict accepted the above formatting, clang-format did make changes.


> 
> > +     if (kstrtou32(buf, 0, &value))
> > +             return -EINVAL;
> > +
> > +     value = !!value;
> 
> Please use kstrtobool() instead of the above code.
Done.

Thanks,
Avri

> 
> Thanks,
> 
> Bart.