Re: [RESEND] PCI: cadence: Add configuration space capability search API
From: Siddharth Vadapalli
Date: Thu Jan 23 2025 - 02:41:29 EST
On Thu, Jan 23, 2025 at 03:09:35PM +0800, Hans Zhang wrote:
> Add configuration space capability search API using struct cdns_pcie*
> pointer.
>
> Similar patches below have been merged.
> commit 5b0841fa653f ("PCI: dwc: Add extended configuration space capability
> search API")
> commit 7a6854f6874f ("PCI: dwc: Move config space capability search API")
Similar patches being merged doesn't sound like a proper reason for
having a feature. Please provide details regarding why this is required.
Assuming that the intent for introducing this feature is to use it
later, it will be a good idea to post the patch for that as well in the
same series.
>
> Signed-off-by: Hans Zhang <18255117159@xxxxxxx>
> ---
> drivers/pci/controller/cadence/pcie-cadence.c | 80 +++++++++++++++++++
> drivers/pci/controller/cadence/pcie-cadence.h | 3 +
> 2 files changed, 83 insertions(+)
[...]
Regards,
Siddharth.