Re: [PATCH net-next v2] ipv4: ip_gre: Fix set but not used warning in ipgre_err() if IPv4-only

From: Paolo Abeni
Date: Thu Jan 23 2025 - 04:36:44 EST


On 1/20/25 2:12 PM, Geert Uytterhoeven wrote:
> if CONFIG_NET_IPGRE is enabled, but CONFIG_IPV6 is disabled:
>
> net/ipv4/ip_gre.c: In function ‘ipgre_err’:
> net/ipv4/ip_gre.c:144:22: error: variable ‘data_len’ set but not used [-Werror=unused-but-set-variable]
> 144 | unsigned int data_len = 0;
> | ^~~~~~~~
>
> Fix this by moving all data_len processing inside the IPV6-only section
> that uses its result.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501121007.2GofXmh5-lkp@xxxxxxxxx/
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

## Form letter - net-next-closed

The merge window for v6.14 has begun. Therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.

Please repost when net-next reopens after Feb 3rd.

RFC patches sent for review only are obviously welcome at any time.

See:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
---
Note: this is possibly somewhat borderline, but I prefer to avoid
exceptions unless there is something really ... exceptional ;)

/P