Re: [RESEND PATCH 1/3] x86/mce/inject: Remova call to mce_notify_irq()

[Nikolay Borisov]

On 22.01.25 г. 20:24 ч., Yazen Ghannam wrote:
> On Wed, Jan 15, 2025 at 09:36:38AM +0200, Nikolay Borisov wrote:
>
> Hi Nikolay,
>
> There is a typo in the $SUBJECT.
>
> > The call is actually a noop because when the MCE is raised the early
> > notifier is the only call site that correctly calls mce_notify_irq()
> > because it also sets mce_need_notify. So let's just remove this call,
> > which allows to unexport mce_notify_irq.
>
> The commit message should be in passive and imperative voice.
>
> "So let's just remove this..." -> "Remove this..."
>
> > Signed-off-by: Nikolay Borisov <nik.borisov@xxxxxxxx>
> > ---
> >   arch/x86/kernel/cpu/mce/core.c   | 1 -
> >   arch/x86/kernel/cpu/mce/inject.c | 1 -
> >   2 files changed, 2 deletions(-)
> >
> > diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
> > index 0dc00c9894c7..23e5e7f7c554 100644
> > --- a/arch/x86/kernel/cpu/mce/core.c
> > +++ b/arch/x86/kernel/cpu/mce/core.c
> > @@ -1793,7 +1793,6 @@ bool mce_notify_irq(void)
> >   	}
> >   	return false;
> >   }
> > -EXPORT_SYMBOL_GPL(mce_notify_irq);
> >
> >   static void __mcheck_cpu_mce_banks_init(void)
> >   {
> > diff --git a/arch/x86/kernel/cpu/mce/inject.c b/arch/x86/kernel/cpu/mce/inject.c
> > index 313fe682db33..06e3cf7229ce 100644
> > --- a/arch/x86/kernel/cpu/mce/inject.c
> > +++ b/arch/x86/kernel/cpu/mce/inject.c
> > @@ -229,7 +229,6 @@ static int raise_local(void)
> >   	} else if (m->status) {
> >   		pr_info("Starting machine check poll CPU %d\n", cpu);
> >   		raise_poll(m);
> > -		mce_notify_irq();
>
> With this change, there are no users of mce_notify_irq() outside of
> mce/core.c. So you could go further and make the function static to
> core.c.
>
> In other words, you could squash the second patch into this one.

Thanks, I've incorporated those in V2 that I sent.

> Thanks,
> Yazen