Re: [PATCH 03/12] dt-bindings: display: mediatek: add EXDMA yaml for MT8196

From: Paul-pl Chen (陳柏霖)
Date: Thu Jan 23 2025 - 11:14:36 EST


On Thu, 2025-01-23 at 08:21 +0100, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On 23/01/2025 07:11, Paul-pl Chen (陳柏霖) wrote:
> >
> > Hi Krzysztof
> >
> > I hope this email finds you well. I have a couple of questions
> > regarding the EXDMA commit patch and decoupling:
> >
> > 1. Would removing the example from the EXDMA commit patch be
> > sufficient
> > to achieve decoupling for EXDMA YAML and MTK clock/power header?
>
> No
>
> >
> > 2. If removing the example from the EXDMA YAML is not allowed, what
> > alternative changes could we implement to achieve decoupling?
>
> Don't use the header constants but just some fake phandle.
>
>
>
> Best regards,
> Krzysztof

Hi Krzysztof,

Once again, thanks for the review and reply.

SO If we apply Chenyu's suggestion:

+ example:
+ -|

+ soc {
+
+ disp_ovl0_exdma2: dma-controller@32850000 {
+ compatible = "mediatek,mt8196-exdma";
+ reg = <0 0x32850000 0 0x1000>;
+ clocks = <13>;
+ power-domains = <12>;
+ mediatek,larb = <88>;
+ iommus = <&mm_smmu 144>;
+ #dma-cells = <1>;
+ };
+ };

Does this work for decoupling?


Best Regards,

Paul