Re: [PATCH v2] net: phy: c45-tjaxx: add delay between MDIO write and read in soft_reset

From: Andrew Lunn
Date: Thu Jan 23 2025 - 11:26:36 EST


On Thu, Jan 23, 2025 at 03:43:46PM +0000, Milos Reljin wrote:
> In application note (AN13663) for TJA1120, on page 30, there's a figure
> with average PHY startup timing values following software reset.
> The time it takes for SMI to become operational after software reset
> ranges roughly from 500 us to 1500 us.
>
> This commit adds 2000 us delay after MDIO write which triggers software
> reset. Without this delay, soft_reset function returns an error and
> prevents successful PHY init.

Is this a fix? Should it be backported to stable? If so:

Fixes: b050f2f15e04 ("phy: nxp-c45: add driver for tja1103")

and it should really indicate the net tree in the Subject: line.

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

Otherwise the patch looks good. Thanks for the updated commit message.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew