Re: [PATCH v3] acpi: Fix HED module initialization order when it is built-in

From: Rafael J. Wysocki
Date: Thu Jan 23 2025 - 14:36:38 EST


On Tue, Jan 21, 2025 at 3:23 AM Xiaofei Tan <tanxiaofei@xxxxxxxxxx> wrote:
>
>
> 在 2025/1/20 19:04, Jonathan Cameron 写道:
> > On Fri, 17 Jan 2025 10:29:57 +0800
> > Xiaofei Tan <tanxiaofei@xxxxxxxxxx> wrote:
> >
> >> When the module HED is built-in, the module HED init is behind EVGED
> >> as the driver are in the same initcall level, then the order is determined
> >> by Makefile order. That order violates expectations. Because RAS records
> >> can't be handled in the special time window that EVGED has initialized
> >> while HED not.
> >>
> >> If the number of such RAS records is more than the APEI HEST error source
> >> number, the HEST resources could be occupied all, and then could affect
> >> subsequent RAS error reporting.
> >>
> >> Change the initcall level of HED to subsys_init to fix the issue. If build
> >> HED as a module, the problem remains. To solve this problem completely,
> >> change the ACPI_HED from tristate to bool.
> >>
> >> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> > Given the change in approach (even though I reviewed this internally)
> > should probably have dropped my RB. Anyhow, consider this me
> > giving it again on list.
> OK. thanks.

Applied as 6.14-rc material with a rewritten changelog and under a new
subject: "ACPI: HED: Always initialize before evged".

Thanks!