Re: [PATCH 3/4] rcu: Update TREE05.boot to test normal synchronize_rcu()

From: Paul E. McKenney
Date: Thu Jan 23 2025 - 15:35:37 EST


On Thu, Jan 23, 2025 at 07:58:27PM +0100, Uladzislau Rezki (Sony) wrote:
> Add extra parameters for rcutorture module. One is the "nfakewriters"
> which is set -1. There will be created number of test-kthreads which
> correspond to number of CPUs in a test system. Those threads randomly
> invoke synchronize_rcu() call.
>
> Apart of that "rcu_normal" is set to 1, because it is specifically for
> a normal synchronize_rcu() testing, also a newly added parameter which
> is "rcu_normal_wake_from_gp" is set to 1 also. That prevents interaction
> with other callbacks in a system.
>
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>

This one looks fine to me.

Reviewed-by: Paul E. McKenney <paulmck@xxxxxxxxxx>

Thanx, Paul

> ---
> tools/testing/selftests/rcutorture/configs/rcu/TREE05.boot | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/testing/selftests/rcutorture/configs/rcu/TREE05.boot b/tools/testing/selftests/rcutorture/configs/rcu/TREE05.boot
> index c419cac233ee..54f5c9053474 100644
> --- a/tools/testing/selftests/rcutorture/configs/rcu/TREE05.boot
> +++ b/tools/testing/selftests/rcutorture/configs/rcu/TREE05.boot
> @@ -2,3 +2,9 @@ rcutree.gp_preinit_delay=3
> rcutree.gp_init_delay=3
> rcutree.gp_cleanup_delay=3
> rcupdate.rcu_self_test=1
> +
> +# This part is for synchronize_rcu() testing
> +rcutorture.nfakewriters=-1
> +rcutorture.gp_sync=1
> +rcupdate.rcu_normal=1
> +rcutree.rcu_normal_wake_from_gp=1
> --
> 2.39.5
>