RE: [PATCH rdma-next 08/13] net/mana: fix warning in the writer of client oob

From: Long Li
Date: Thu Jan 23 2025 - 17:49:03 EST


> Subject: [PATCH rdma-next 08/13] net/mana: fix warning in the writer of client
> oob
>
> From: Konstantin Taranov <kotaranov@xxxxxxxxxxxxx>
>
> Do not warn on missing pad_data when oob is in sgl.
>
> Signed-off-by: Konstantin Taranov <kotaranov@xxxxxxxxxxxxx>
> Reviewed-by: Shiraz Saleem <shirazsaleem@xxxxxxxxxxxxx>

Reviewed-by: Long Li <longli@xxxxxxxxxxxxx>

> ---
> drivers/net/ethernet/microsoft/mana/gdma_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c
> b/drivers/net/ethernet/microsoft/mana/gdma_main.c
> index 3cb0543..a8a9cd7 100644
> --- a/drivers/net/ethernet/microsoft/mana/gdma_main.c
> +++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c
> @@ -1042,7 +1042,7 @@ static u32 mana_gd_write_client_oob(const struct
> gdma_wqe_request *wqe_req,
> header->inline_oob_size_div4 = client_oob_size / sizeof(u32);
>
> if (oob_in_sgl) {
> - WARN_ON_ONCE(!pad_data || wqe_req->num_sge < 2);
> + WARN_ON_ONCE(wqe_req->num_sge < 2);
>
> header->client_oob_in_sgl = 1;
>
> --
> 2.43.0