Re: [PATCH 4/5] arm64: dts: ti: k3-am62a-wakeup: Add ddr-pmctrl, canuart-wake

[Krzysztof Kozlowski]

On Wed, Jan 22, 2025 at 11:24:35AM +0100, Markus Schneider-Pargmann wrote:
> Within the wkup-conf register range there are ddr-pmctrl and
> canuart-wake control registers. Add dedicated subnodes for these.
> 
> Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
> index 0b1dd5390cd3f42b0ec56bab042388722b4c22a1..a9bcda212c99d2f7669100ca29459eb13172da3e 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
> @@ -36,6 +36,16 @@ usb1_phy_ctrl: syscon@4018 {
>  			compatible = "ti,am62-usb-phy-ctrl", "syscon";
>  			reg = <0x4018 0x4>;
>  		};
> +
> +		ddr_pmctrl: syscon@80d0 {
> +			compatible = "ti,am62-ddr-pmctrl", "syscon";
> +			reg = <0x80d0 0x4>;

No, why do you export single registers? Entire device is syscon, not
single register.

Best regards,
Krzysztof