Re: [PATCH 2/3] cgroup/rstat: Cleanup cpu.stat once for all

From: Abel Wu
Date: Fri Jan 24 2025 - 05:00:53 EST




On 1/24/25 5:22 PM, Michal Koutný Wrote:
On Fri, Jan 24, 2025 at 01:47:02AM +0800, Abel Wu <wuyun.abel@xxxxxxxxxxxxx> wrote:
-static void cgroup_force_idle_show(struct seq_file *seq, struct cgroup_base_stat *bstat)
+static void __append_bstat(struct seq_file *seq, struct cgroup_base_stat *bstat,
+ struct bstat_entry *entry)

Not sure if starting with double underscore is needed when the helper is
`static`. Also something like s/append/show/ -> cgroup_bstat_entry_show.

Yeah, "cgroup_bstat_entry_show" looks better! Will fix.

Thanks,
Abel