Re: [PATCH v2 1/5] dt-bindings: clock: qcom: Add compatible for QCM6490 boards

[Taniya Das]

On 9/16/2024 2:10 PM, Krzysztof Kozlowski wrote:
> On 13/09/2024 07:18, Taniya Das wrote:
> > On 8/17/2024 2:51 PM, Krzysztof Kozlowski wrote:
> > > On 16/08/2024 10:32, Taniya Das wrote:
> > > > Add the new QCM6490 compatible to support the reset functionality for
> > > > Low Power Audio subsystem.
> > > >
> > > > Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx>
> > >
> > > Subject is odd - I do not see here anything related to boards.
> > >
> > > Anyway, this is incomplete. Look at the rest of the binding - you did
> > > not update any part related to proper clock constraints.
> >
> > Not sure if I understand the concern, but I was of the opinion that I
> > have added a new compatible for QCM6490 board , but no new clock
> > constraint added.
> >
> >
> > I see a patch from you
> > https://lore.kernel.org/all/20240817094605.27185-1-krzysztof.kozlowski@xxxxxxxxxx/
> > and I guess it fixes the constraints.
>
> Look at entire file. This is incomplete.

Please accept apologies for taking longer than expected to respond on 
this thread.

Yes I think you meant something as below to be taken care as 
constraints, which I have overlooked in my earlier patch.


@@ -26,6 +26,7 @@ properties:

   compatible:
     enum:
+      - qcom,qcm6490-lpassaudiocc
       - qcom,sc7280-lpassaoncc
       - qcom,sc7280-lpassaudiocc
       - qcom,sc7280-lpasscorecc
@@ -125,6 +126,18 @@ allOf:

         reg:
           maxItems: 1
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: qcom,qcm6490-lpassaudiocc
+
+    then:
+      properties:
+        reg:
+          items:
+            - description: lpass core cc register
+            - description: lpass audio csr register

> Best regards,
> Krzysztof

--
Thanks & Regards,
Taniya Das.