Re: [PATCH] s390/mm: Add missing ctor/dtor on page table upgrade

[Kevin Brodsky]

On 24/01/2025 09:24, Alexander Gordeev wrote:
>>>  	}
>>>  	if (end > _REGION1_SIZE) {
>>>  		pgd = crst_table_alloc(mm);
>>>  		if (unlikely(!pgd))
>>>  			goto err_pgd;
>>>  		crst_table_init(pgd, _REGION1_ENTRY_EMPTY);
>>> +		pagetable_pgd_ctor(virt_to_ptdesc(pgd));
>> I was hoping this might be equivalent to pgd_alloc() but it does not
>> include a call to crst_table_init(). Since adding it would be apparently
>> undesirable (having read the other thread), it seems reasonable to add
>> the explicit constructor call.
> We were thinking about a follow-up cleanup that addresses it all, but this
> patch is a targeted fix to catch up your and Qi Zheng series in the still
> open merge window.

Sure that's fair, this patch does fix the issue and the cleanup can wait
until the next cycle.

Reviewed-by: Kevin Brodsky <kevin.brodsky@xxxxxxx>

- Kevin