RE: [PATCH v4 3/9] soc: renesas: rz-sysc: Move RZ/G3S SoC detection to the SYSC driver

[John Madieu]

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Friday, January 24, 2025 3:18 PM
> Subject: Re: [PATCH v4 3/9] soc: renesas: rz-sysc: Move RZ/G3S SoC
> detection to the SYSC driver
> 
> Hi John,
> 

Hi Geert,

Thanks for your review.

> On Thu, Jan 23, 2025 at 6:05 PM John Madieu
> <john.madieu.xa@xxxxxxxxxxxxxx> wrote:
> > From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> >
> > Now that we have SoC detection in the RZ SYSC driver, move the RZ/G3S
> > SoC detection to it. The SYSC provides SoC ID in its own registers.
> >
> > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> > Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > +#define SYS_LSI_DEVID_SPECIFIC GENMASK(27, 0)
> > +#define SYS_MAX_REG            0xe20
> 
> Unused.

Will be removed in v5.

> 
> > +
> 
> The rest LGTM, so with the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
Regards,
John