Re: [PATCH v2] scsi: ufs: core: Ensure clk_gating.lock is used only after initialization

From: Bart Van Assche
Date: Fri Jan 24 2025 - 12:48:00 EST


On 1/23/25 11:33 PM, Avri Altman wrote:
+ /*
+ * Initialize clk_gating.lock early since it is being used in
+ * ufshcd_setup_clocks()
+ */
+ if (ufshcd_is_clkgating_allowed(hba))
+ spin_lock_init(&hba->clk_gating.lock);

Initializing a spinlock is a very fast operation so please do this
unconditionally.

Thanks,

Bart.