Re: [PATCH 1/2] clocksource: Use pr_info() for "Checking clocksource synchronization" message
From: Paul E. McKenney
Date: Fri Jan 24 2025 - 15:16:38 EST
On Fri, Jan 24, 2025 at 01:59:22PM -0500, Waiman Long wrote:
> The "Checking clocksource synchronization" message is normally printed
> when clocksource_verify_percpu() is called for a given clocksource if
> both the CLOCK_SOURCE_UNSTABLE and CLOCK_SOURCE_VERIFY_PERCPU flags
> are set. It is an informational message and so pr_info() should be used
> instead of pr_warn().
>
> Signed-off-by: Waiman Long <longman@xxxxxxxxxx>
Reviewed-by: Paul E. McKenney <paulmck@xxxxxxxxxx>
> ---
> kernel/time/clocksource.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
> index 7304d7cf47f2..77d9566d3aa6 100644
> --- a/kernel/time/clocksource.c
> +++ b/kernel/time/clocksource.c
> @@ -382,7 +382,8 @@ void clocksource_verify_percpu(struct clocksource *cs)
> return;
> }
> testcpu = smp_processor_id();
> - pr_warn("Checking clocksource %s synchronization from CPU %d to CPUs %*pbl.\n", cs->name, testcpu, cpumask_pr_args(&cpus_chosen));
> + pr_info("Checking clocksource %s synchronization from CPU %d to CPUs %*pbl.\n",
> + cs->name, testcpu, cpumask_pr_args(&cpus_chosen));
> for_each_cpu(cpu, &cpus_chosen) {
> if (cpu == testcpu)
> continue;
> --
> 2.47.1
>