Re: [PATCH v4 2/6] kernfs: Acquire kernfs_rwsem in kernfs_get_parent_dentry().

[Tejun Heo]

On Fri, Jan 24, 2025 at 06:46:10PM +0100, Sebastian Andrzej Siewior wrote:
> kernfs_get_parent_dentry() passes kernfs_node::parent to
> kernfs_get_inode().
> 
> Acquire kernfs_root::kernfs_rwsem to ensure kernfs_node::parent isn't
> replaced during the operation.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

This looks fine but wouldn't it be better to use kernfs_rename_lock instead?

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

-- 
tejun