Re: [PATCH] posix-clock: Remove duplicate ioctl handler

[Arnd Bergmann]

On Sat, Jan 25, 2025, at 11:20, Thomas Weißschuh wrote:
>  static int posix_clock_open(struct inode *inode, struct file *fp)
>  {
>  	int err;
> @@ -174,7 +154,7 @@ static const struct file_operations 
> posix_clock_file_operations = {
>  	.open		= posix_clock_open,
>  	.release	= posix_clock_release,
>  #ifdef CONFIG_COMPAT
> -	.compat_ioctl	= posix_clock_compat_ioctl,
> +	.compat_ioctl	= posix_clock_ioctl,
>  #endif

I would remove the #ifdef/#endif as well here. I would also suggest
using compat_ptr_ioctl(), so on s390 the pointers get converted
correctly, even if it clears the upper bit on the integer arguments.

      Arnd