Re: [PATCH 3/6] phy: qcom: qmp-pcie: Add X1P42100 Gen4x4 PHY

From: Dmitry Baryshkov
Date: Sat Jan 25 2025 - 12:30:42 EST


On Sat, Jan 25, 2025 at 04:31:19AM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> Add a new, common configuration for Gen4x4 V6 PHYs without an init
> sequence.
>
> The bootloader configures the hardware once and the OS retains that
> configuration by using the NOCSR reset line (which doesn't drop
> register state on assert) in place of the "full reset" one.

I know your opinion, but my 2c would still be for not depending on the
bootloader. I think that was the rule for ages for many possible
reasons.

>
> Use this new configuration for X1P42100's Gen4x4 PHY.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)

--
With best wishes
Dmitry