Re: [PATCH 1/2] hwmon: add driver for HTU31

[Guenter Roeck]

On 1/26/25 06:40, Andrei Lalaev wrote:
> Add base support for HTU31 temperature and humidity sensor.
>
> Besides temperature and humidity values, the driver also exports a 24-bit
> serial number and heater control to sysfs.
>
> Signed-off-by: Andrei Lalaev <andrey.lalaev@xxxxxxxxx>
> ---
...
> +
> +static struct attribute *htu31_attrs[] = {
> +	&dev_attr_heater_enable.attr,
> +	&dev_attr_serial_number.attr,

I'll accept the heater enable attribute as sysfs attribute,
but the serial number is most definitely not a hardware monitoring
attribute. Please expose is through debugfs.

Thanks,
Guenter