Re: [PATCH AUTOSEL 6.13 06/16] tool api fs: Correctly encode errno for read/write open failures
From: Namhyung Kim
Date: Sun Jan 26 2025 - 15:41:51 EST
Hello,
On Sun, Jan 26, 2025 at 10:27 AM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> On Sun, Jan 26, 2025 at 7:07 AM Sasha Levin <sashal@xxxxxxxxxx> wrote:
> >
> > From: Ian Rogers <irogers@xxxxxxxxxx>
> >
> > [ Upstream commit 05be17eed774aaf56f6b1e12714325ca3a266c04 ]
> >
> > Switch from returning -1 to -errno so that callers can determine types
> > of failure.
>
> Hi Sasha,
>
> This change requires changes in the perf tool. The issue is the -1
> gets written to perf.data files in the topology, the -errno value is
> "corrupt." Because of this, I'd suggest not backporting this change.
Agreed. Please remove this patch from the all stable series.
Thanks,
Namhyung