Re: [PATCH v1 1/6] tools/build: Don't pass test log files to linker

From: Namhyung Kim
Date: Sun Jan 26 2025 - 15:44:00 EST


On Fri, Jan 24, 2025 at 05:58:37PM -0800, Ian Rogers wrote:
> On Fri, Jan 24, 2025 at 3:31 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> >
> > On Fri, Oct 25, 2024 at 10:22:58AM -0700, Ian Rogers wrote:
> > > Separate test log files from object files. Depend on test log output
> > > but don't pass to the linker.
> >
> > I don't know why $(obj-y) contains log files in the first place. It's
> > supposed to have .o files only, right?
>
> There's context here:
> https://lore.kernel.org/all/20231129213428.2227448-1-irogers@xxxxxxxxxx/
> $(obj-y) is the set of the dependencies from Build files, generally
> directories or .o files. Perf added the test logs as the alternative
> is to duplicate all the directory scanning and other logic for a
> $(test-y) but it isn't clear how you'd even name targets for a test in
> the Build files. Rather than reinvent Makefile.build the choice was
> made to work with what we had.

Thanks for the explanation. I'm ok with it for now but I'll take a look
if there's a better way later.

Thanks,
Namhyung