Re: [PATCH v3 2/2] scsi: ufs: Fix toggling of clk_gating.state when clock gating is not allowed

[Bean Huo]

On Sun, 2025-01-26 at 08:45 +0200, Avri Altman wrote:
>         } else if (!ret && on && hba->clk_gating.is_initialized) {
>                 scoped_guard(spinlock_irqsave, &hba->clk_gating.lock)
>                         hba->clk_gating.state = CLKS_ON;
>                 trace_ufshcd_clk_gating(dev_name(hba->dev)

Consolidating all clock-related initialization into a single function,
such as ufshcd_init_clocks(), should be considered.