Re: [PATCH v2 17/22] media: dt-bindings: ti,ds90ub960: Add ti,enable-sscg property

[Krzysztof Kozlowski]

On Fri, Jan 24, 2025 at 05:17:54PM +0200, Tomi Valkeinen wrote:
> From: Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx>
> 
> Spread-spectrum clock generation is supported by UB9702, but only
> optionally required depending upon the hardware. Add a device-tree

What does "optionally required" mean? Either it is required or it is
optional.

> property for enabling SSCG.
> 
> Signed-off-by: Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
> ---
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> Cc: Conor Dooley <conor+dt@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> index 0b71e6f911a8..970f0f36449a 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> @@ -43,6 +43,11 @@ properties:
>      minItems: 1
>      maxItems: 32
>  
> +  ti,enable-sscg:
> +    type: boolean
> +    description:
> +      Enable Spread-Spectrum Clock Generator for the BC clock for all ports.

And the SSC values are not configurable?

I don't want three bindings for the same (see IMX8, STM32 and pull
request in dtschema), so be sure all your cases fit Dario's and Peng's
work.

Best regards,
Krzysztof