Re: [PATCH net 0/3] net: stmmac: Fix usage of maximum queue number macros
From: Russell King (Oracle)
Date: Mon Jan 27 2025 - 04:52:07 EST
On Mon, Jan 27, 2025 at 06:24:47PM +0900, Kunihiko Hayashi wrote:
> The maximum number of Rx and Tx queues is defined by MTL_MAX_RX_QUEUES and
> MTL_MAX_TX_QUEUES respectively.
>
> There are some places where Rx and Tx are used in reverse. Currently these
> two values as the same and there is no impact, but need to fix the usage
> to keep consistency.
I disagree that this should be targetting the net tree - I think it
should be the net-next tree. Nothing is currently broken, this isn't
fixing a regression, there is no urgent need to get it into mainline.
It is merely a cleanup because both macros have the same value:
include/linux/stmmac.h:#define MTL_MAX_RX_QUEUES 8
include/linux/stmmac.h:#define MTL_MAX_TX_QUEUES 8
Please re-send for net-next after the merge window and net-next has
re-opened.
In any case, for the whole series:
Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!