Re: [PATCH bpf v2 1/2] samples/hid: remove unnecessary -I flags from libbpf EXTRA_CFLAGS

[Nicolas Schier]

On Mon, Jan 27, 2025 at 03:37:56AM -0600, Jinghao Jia wrote:
> On 1/27/25 3:29 AM, Nicolas Schier wrote:
> > On Thu, Jan 23, 2025 at 02:19:49AM -0600, Jinghao Jia wrote:
> >> Commit 5a6ea7022ff4 ("samples/bpf: Remove unnecessary -I flags from
> >> libbpf EXTRA_CFLAGS") fixed the build error caused by redundant include
> >> path for samples/bpf, but not samples/hid.
> >>
> >> Apply the same fix on samples/hid as well.
> >>
> >> Fixes: 13b25489b6f8 ("kbuild: change working directory to external module directory with M=")
> > 
> > I can't see a relation between this patch and the referenced commit.
> > Can you please check whether the 'Fixes' is (still?) valid here?
> > 
> > Kind regards,
> > Nicolas
> > 
> 
> The 'Fixes' is from commit 5a6ea7022ff4 ("samples/bpf: Remove unnecessary
> -I flags from libbpf EXTRA_CFLAGS") that fixes the equivalent issue in
> samples/bpf --- according to its commit message, commit 13b25489b6f8
> ("kbuild: change working directory to external module directory with M=")
> is the commit that breaks the libbpf build in the samples.

ah sorry, I should have read 5a6ea7022ff4 before.  Thanks for
clarification.

Kind regards,
Nicolas