Re: [PATCH] serial: 8250_pci: Fix Warning at drivers/pci/devres.c:603 pcim_add_mapping_to_legacy_table

From: Helge Deller
Date: Mon Jan 27 2025 - 08:14:31 EST


On 1/26/25 08:37, Helge Deller wrote:
Some PA-RISC servers have BMC management cards (Diva) with up to 5 serial
UARTS per memory PCI bar. This triggers since at least kernel 6.12 for each of
the UARTS (beside the first one) the following warning in devres.c:
...

I see three options to avoid this warning:
a) drop the WARNING() from devrec.c,
b) modify pcim_iomap() to return an existing mapping if it exists
instead of creating a new mapping, or
c) change serial8250_pci_setup_port() to only create a new mapping
if none exists yet.

This patch implements option c).

Please ignore this patch as it behaves wrong.
I'll send an updated patch.

Helge