Re: [PATCH 1/3] dt-bindings: fpga: stratix10: Convert to json-schema

From: Mahesh Rao
Date: Mon Jan 27 2025 - 11:31:46 EST


Hi Conor Dooley,

Thanks for reviewing the patch.

On Wed, 22 Jan 2025 18:35:51 +0000, Conor Dooley wrote:
> > Convert intel,stratix10-soc fpga manager devicetree binding file from
> > freeform format to json-schema.
> >
> > Signed-off-by: Mahesh Rao <mahesh.rao@xxxxxxxxx>
> > +maintainers:
> > + - Moritz Fischer <mdf@xxxxxxxxxx>
>
> Are these maintainers actually correct? Does Moritz work on Altera stuff, or
> did you just add him cos he is a subsystem maintainer? Really what's here
> should be people that understand the hardware.
>

Sorry I initially had added list from maintaner script,I will change to
people who works with the hardware in the next revision.

> > + - Wu Hao <hao.wu@xxxxxxxxx>
> > + - Xu Yilun <yilun.xu@xxxxxxxxx>
> > +
> > +description: |
>
> The | here isn't needed, nor is point out that this is a binding in the line
> below. Please describe what the hardware is here instead.
>

Sure I will update the info in the next revision.

Best regards
Mahesh Rao