Re: [PATCH v2] sched_ext: Move built-in idle CPU selection policy to a separate file

From: Tejun Heo
Date: Mon Jan 27 2025 - 14:19:29 EST


On Sat, Jan 25, 2025 at 10:39:11PM +0100, Andrea Righi wrote:
...
> @@ -7823,6 +7110,12 @@ static int __init scx_init(void)
> &scx_kfunc_set_unlocked)) ||
> (ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_SYSCALL,
> &scx_kfunc_set_unlocked)) ||
> + (ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_STRUCT_OPS,
> + &scx_kfunc_set_idle)) ||
> + (ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_TRACING,
> + &scx_kfunc_set_idle)) ||
> + (ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_SYSCALL,
> + &scx_kfunc_set_idle)) ||

Just one more change. Can you please make the set themselves static in
ext_idle.c and then register them from its own init function which is called
from scx_init()?

Thanks.

--
tejun