Re: [PATCH v1 25/29] cxl/amd: Enable Zen5 address translation using ACPI PRMT

From: Robert Richter
Date: Tue Jan 28 2025 - 04:29:28 EST


On 17.01.25 15:32:25, Ben Cheatham wrote:
> On 1/7/25 8:10 AM, Robert Richter wrote:

> > +static u64 cxl_zen5_to_hpa(struct cxl_decoder *cxld, u64 hpa)
>
> After reading through your discussion with Gregory I'm not confused about the function name
> anymore, but I would definitely include a comment specifying the expected usage and return value.

I am going to add that description to struct cxl_port where the
callback is implemented.

Thanks for review,

-Robert