Re: [PATCH v10 bpf-next 6/7] bpf: fs/xattr: Add BPF kfuncs to set and remove xattrs

[Christian Brauner]

On Fri, Jan 24, 2025 at 12:29:10PM -0800, Song Liu wrote:
> Add the following kfuncs to set and remove xattrs from BPF programs:
> 
>   bpf_set_dentry_xattr
>   bpf_remove_dentry_xattr
>   bpf_set_dentry_xattr_locked
>   bpf_remove_dentry_xattr_locked
> 
> The _locked version of these kfuncs are called from hooks where
> dentry->d_inode is already locked. Instead of requiring the user
> to know which version of the kfuncs to use, the verifier will pick
> the proper kfunc based on the calling hook.
> 
> Signed-off-by: Song Liu <song@xxxxxxxxxx>
> ---

Seems ok to me,
Acked-by: Christian Brauner <brauner@xxxxxxxxxx>