Re: [PATCH v3 0/2] Fixup drm_atomic_helper_connector_hdmi_check()

[Cristian Ciocaltea]

Hi Maxime,

On 1/28/25 11:58 AM, Maxime Ripard wrote:
> Hi,
> 
> On Tue, Jan 14, 2025 at 08:16:55PM +0200, Cristian Ciocaltea wrote:
>> Fix a NULL pointer dereference discovered while unloading a DRM module
>> and provide a test to make sure the helper works as expected in case the
>> connector's CRTC is shut down.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>
> 
> I'm sorry, I didn't realize it at the time but it looks like it was made
> redundant by another series that got merged about the same time you were
> sending this one:
> 
> https://patchwork.freedesktop.org/series/143378/
> 
> Sorry again,

No worries.

I checked the merged series and I think some bits from this series are
still applicable:

* Simplify the NULL verification by considering only the return of
connector_state_get_mode(), which gets rid of the redundant
'new_conn_state->crtc' check, but also covers the additional checks
already performed in that function.

* Update the newly introduced test case to also verify
{mode|connectors|active}_changed.

I could send those as v4, but probably it makes sense to drop this
series and start a new one - please let me know if you have a preference
here.

Thanks,
Cristian