Re: [PATCH] drm/vkms: Add support for ABGR8888 pixel format

From: Paz Zcharya
Date: Tue Jan 28 2025 - 10:09:06 EST


On Tue, Jan 28, 2025 at 11:04:33AM +0100, Louis Chauvet wrote:
> On 27/01/25 - 23:59, Paz Zcharya wrote:
> > Add support for pixel format ABGR8888, which is the default format
> > on Android devices. This will allow us to use VKMS as the default
> > display driver in Android Emulator (Cuttlefish) and increase VKMS
> > adoption.
> >
> > Changes in v2:
> > - Rebased on top of tip of tree because it has been 3 months.
> > - No functional changes.
> >
> > Signed-off-by: Paz Zcharya <pazz@xxxxxxxxxx>
>
> Hi Paz,
>
> Reviewed-by: Louis Chauvet <louis.chauvet@xxxxxxxxxxx>
>
> When applying a patch I got a small warning about a missmatch between your
> author email and the Signed-off-by:
>
> -:106: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Paz Zcharya <pazz@xxxxxxxxxxxx>' != 'Signed-off-by: Paz Zcharya <pazz@xxxxxxxxxx>'
>
> I can fix it for you by adding a Author: / changing the Sign-of-by before
> applying on drm-misc-next.
>
> What mail do you want to use? pazz@xxxxxxxxxx or pazz@xxxxxxxxxxxx?
>
> Thanks!
> Louis Chauvet

Thank you for the quick review, Louis!

Let's use pazz@xxxxxxxxxx.
I apologize about the mistake -- I'll make sure to fix that in the
future.

Greatly appericiate your help!

Thanks a lot,
Paz