Re: [PATCH v3 09/10] drm/bridge: allow limiting I2S formats

[Maxime Ripard]

On Sun, Jan 26, 2025 at 03:29:14PM +0200, Dmitry Baryshkov wrote:
> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index b55e80a57758e8b652eac0cd01cb245a04e221f5..d16af5fe90cb48f6671e798d9dee61a359c9233f 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -920,6 +920,11 @@ struct drm_bridge {
>  	 */
>  	int hdmi_audio_max_i2s_playback_channels;
>  
> +	/**
> +	 * @hdmi_audio_i2s_formats: supported I2S formats, optional
> +	 */
> +	u64 hdmi_audio_i2s_formats;
> +

We should document what the default value is if it's optional.

Once fixed:
Reviewed-by: Maxime Ripard <mripard@xxxxxxxxxx>

Maxime

Attachment: signature.asc
Description: PGP signature