Re: [PATCH v3 08/10] drm/display: bridge-connector: handle CEC adapters

[Maxime Ripard]

On Sun, Jan 26, 2025 at 03:29:13PM +0200, Dmitry Baryshkov wrote:
>  /* -----------------------------------------------------------------------------
>   * Bridge Connector Initialisation
>   */
> @@ -633,6 +711,21 @@ struct drm_connector *drm_bridge_connector_init(struct drm_device *drm,
>  			if (ret)
>  				return ERR_PTR(ret);
>  		}
> +
> +		if (bridge->hdmi_cec_adapter_name) {
> +			if (!bridge->funcs->hdmi_cec_enable ||
> +			    !bridge->funcs->hdmi_cec_log_addr ||
> +			    !bridge->funcs->hdmi_cec_transmit)
> +				return ERR_PTR(-EINVAL);
> +
> +			ret = drm_connector_hdmi_cec_register(connector,
> +							      &drm_bridge_connector_hdmi_cec_ops,
> +							      bridge->hdmi_cec_adapter_name,
> +							      bridge->hdmi_cec_available_las,
> +							      bridge->hdmi_dev);
> +			if (ret)
> +				return ERR_PTR(ret);
> +		}

Maybe we can use a different bridge feature flag to trigger the CEC code
support instead?

Maxime

Attachment: signature.asc
Description: PGP signature