Re: [PATCH net] net: dsa: mv88e6xxx: Fix switchdev error code

[Vladimir Oltean]

On Sun, Jan 26, 2025 at 10:07:26PM +0000, Elliot Ayrey wrote:
> On Tue, 2024-12-17 at 10:54 +0100, Andrew Lunn wrote:
> > I just had a quick look at other users of call_switchdev_notifiers()
> > and all but vxlan_core.c and this one discarded the return
> > value. Would that be a better fix, making the code more uniform?
> > 
> > 	Andrew
> 
> Hi Andrew, I am hesitant to remove this error as it was very helpful
> during development and helped to diagnose some subtle issues that would
> have otherwise been very hard to notice.

Can you give more details about how you encountered this issue?
One could similarly argue that a call_switchdev_notifiers() error was
ignored until now, and maybe the system still did something reasonable
and thus, properly handling the error now risks introducing a regression
for them. No way to really know except if the commit author (you) makes
a reasonable analysis in the commit message leading to the conclusion
that the patch is worthy of backporting to stable kernels (i.e. fixes a
user-visible incorrect behavior).