Re: [PATCH 1/2] dt-bindings: net: wireless: describe the ath12k AHB module
From: Raj Kumar Bhagat
Date: Tue Jan 28 2025 - 12:34:54 EST
On 1/28/2025 3:51 PM, Krzysztof Kozlowski wrote:
> On 28/01/2025 10:29, Raj Kumar Bhagat wrote:
>> On 1/28/2025 2:47 PM, Krzysztof Kozlowski wrote:
>>> On 28/01/2025 10:10, Raj Kumar Bhagat wrote:
>>>> Add device-tree bindings for the ATH12K module found in the IPQ5332
>>>> device.
>>>>
>>>> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@xxxxxxxxxxx>
>>>> ---
>>>> .../net/wireless/qcom,ath12k-ahb.yaml | 317 ++++++++++++++++++
>>>> 1 file changed, 317 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml
>>>
>>> It was v4, now v1? So entire previous discussion and feedback is
>>> missing? Go to previous series and implement entire feedback. Then use
>>> proper versioning, proper changelog and make it obvious/understandable
>>> to us, instead of sending v1 after v4 in entirely separate thread.
>>>
>>
>> I was asked to send DTS as a separate series, this is a new series for
>> DTS hence stated with v1.
>
>
> But we do not talk about DTS here, but bindings.
>
>
>> To address the undocumented ABIs we have changes in dt-binding and hence
>
> That's v1 so how it could have changes in the first place? Unless this
> is v5?
>
Sure, I understand your point now.
I shouldn't have sent dt-binding here along with DTS as v1. dt-binding should
go with wireless patch-set in v5.
Let me know your thoughts on the next steps:
1. I will send v5 for 'wifi: ath12k: add Ath12k AHB driver support for IPQ5332'
along with dt-binding.
2. In a separate series, I will send only DTS changes as v2, considering the
review comments in this version as v1 for DTS.