Re: [PATCH] wifi: mwifiex: Constify struct mwifiex_if_ops

From: Kalle Valo
Date: Tue Jan 28 2025 - 13:13:07 EST


Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote:

> 'struct mwifiex_if_ops' are not modified in these drivers.
>
> Constifying these structures moves some data to a read-only section, so
> increase overall security, especially when the structure holds some
> function pointers.
>
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
> text data bss dec hex filename
> 61439 4367 32 65838 1012e drivers/net/wireless/marvell/mwifiex/pcie.o
>
> After:
> =====
> text data bss dec hex filename
> 61699 4127 32 65858 10142 drivers/net/wireless/marvell/mwifiex/pcie.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Patch applied to wireless-next.git, thanks.

e50e30fa966e wifi: mwifiex: Constify struct mwifiex_if_ops

--
https://patchwork.kernel.org/project/linux-wireless/patch/03d524b72f20a0302e4de5e0ebdc20ab69469dec.1737308889.git.christophe.jaillet@xxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches