Re: [PATCH 0/2] wifi: mac80211: Deadcode cleanup

From: Dr. David Alan Gilbert
Date: Tue Jan 28 2025 - 13:39:34 EST


* linux@xxxxxxxxxxx (linux@xxxxxxxxxxx) wrote:
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> Hi,
> This pair of patches removes a bunch of functions that haven't
> been called for more than a few years.
>
> I suspect I could go further; in particular I wonder
> if
> ieee80211_debugfs_key_remove_beacon_default()
> and
> ieee80211_debugfs_key_remove_mgmt_default()
>
> could go together with a data structure somewhere?
>
> Also, ieee80211_nan_func_match() was the last use of
> cfg80211_nan_match(); but that would be in a separate area.
>
> Dave
>
> Dr. David Alan Gilbert (2):
> wifi: mac80211: Clean up debugfs_key deadcode
> wifi: mac80211: Remove unused ieee80211_nan_func_match

Hi,
I noticed one of these patches (debugfs_key) has landed in 6.14
but the other one I don't think has - any particular reason?

Dave

>
> include/net/mac80211.h | 15 ------------
> net/mac80211/cfg.c | 25 --------------------
> net/mac80211/debugfs_key.c | 47 --------------------------------------
> net/mac80211/debugfs_key.h | 15 ------------
> 4 files changed, 102 deletions(-)
>
> --
> 2.47.1
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/