Re: [PATCH] ASoC: soc-core: Stop using of_property_read_bool() for non-boolean properties
From: Rob Herring
Date: Tue Jan 28 2025 - 15:24:56 EST
On Wed, Jan 22, 2025 at 2:21 AM Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:
>
> On R-Car:
>
> OF: /sound: Read of boolean property 'simple-audio-card,bitclock-master' with a value.
> OF: /sound: Read of boolean property 'simple-audio-card,frame-master' with a value.
>
> or:
>
> OF: /soc/sound@ec500000/ports/port@0/endpoint: Read of boolean property 'bitclock-master' with a value.
> OF: /soc/sound@ec500000/ports/port@0/endpoint: Read of boolean property 'frame-master' with a value.
>
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
>
> Replace testing for presence before calling of_property_read_u32() by
> testing for an -EINVAL return value from the latter, to simplify the
> code.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> Seen since commit c141ecc3cecd7647 ("of: Warn when
> of_property_read_bool() is used on non-boolean properties") in
> dt-rh/for-next.
>
> I could not exercise all code paths, so review/testing would be
> appreciated. Thanks!
> ---
> sound/soc/soc-core.c | 32 +++++++++++++-------------------
> 1 file changed, 13 insertions(+), 19 deletions(-)
Acked-by: Rob Herring (Arm) <robh@xxxxxxxxxx>